Fix loading the proper home-$posttype.php file and fix phpunit - #6
Closed
losted wants to merge 2 commits into
Closed
Fix loading the proper home-$posttype.php file and fix phpunit#6losted wants to merge 2 commits into
losted wants to merge 2 commits into
Conversation
Owner
|
Salut @losted, Thanks for the PR. The current version is a bit messy and I recently started to rewrite the whole plugin with better code, tests, etc. in order to release a proper/stable version 1. You can track progress in #7. The issue you're fixing is already fixed in that branch. I'll be glad if you could give it a try. The plugin didn't change much, only making base post type slug replacement optional: 
I'll notify you when it's ready to be released (should be quite soon). |
Contributor
Author
|
I tried the branch it works perfectly! We don't need a stable version right away but I'll keep an eye for the release of 1.0! Merci! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this issue: #5
I added
.phpinset_home_template_hierarchy()so that it load the right template file for custom post type archives.Also removed the prefix and suffix in
phpunit.xml.distand renamed the test file/class so that PHPUnit properly find it.